Skip to content

Fix incorrect log formatting in DruidKerberosAuthenticationHandler. #4817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jon-wei merged 1 commit into from
Sep 18, 2017
Merged

Fix incorrect log formatting in DruidKerberosAuthenticationHandler. #4817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ...kerberos/src/main/java/io/druid/security/kerberos/DruidKerberosAuthenticationHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,7 @@ public void init(Properties config) throws ServletException
}

for (String spnegoPrincipal : spnegoPrincipals) {
log.info("Login using keytab {}, for principal {}",
keytab, spnegoPrincipal
);
log.info("Login using keytab %s, for principal %s", keytab, spnegoPrincipal);
final KerberosAuthenticator.DruidKerberosConfiguration kerberosConfiguration =
new KerberosAuthenticator.DruidKerberosConfiguration(keytab, spnegoPrincipal);
final LoginContext loginContext =
Expand All @@ -117,7 +115,7 @@ public void init(Properties config) throws ServletException
loginContext.login();
}
catch (LoginException le) {
log.warn(le, "Failed to login as [{}]", spnegoPrincipal);
log.warn(le, "Failed to login as [%s]", spnegoPrincipal);
throw new AuthenticationException(le);
}
loginContexts.add(loginContext);
Expand Down Expand Up @@ -201,7 +199,7 @@ public AuthenticationToken run() throws Exception
String userName = kerberosName.getShortName();
token = new AuthenticationToken(userName, clientPrincipal, getType());
response.setStatus(HttpServletResponse.SC_OK);
log.trace("SPNEGO completed for principal [{}]", clientPrincipal);
log.trace("SPNEGO completed for principal [%s]", clientPrincipal);
}
}
finally {
Expand Down