Remove SegmentLoaderConfig.numLoadingThreads config#4829
Merged
drcrallen merged 1 commit intoapache:masterfrom Sep 21, 2017
Merged
Remove SegmentLoaderConfig.numLoadingThreads config#4829drcrallen merged 1 commit intoapache:masterfrom
drcrallen merged 1 commit intoapache:masterfrom
Conversation
jihoonson
approved these changes
Sep 21, 2017
Contributor
|
Looks that the CI failure is not relevant to this patch. |
drcrallen
approved these changes
Sep 21, 2017
Contributor
|
@leventov can you do the backport please? |
Contributor
|
Marked release notes, it deserves a mention since a config parameter has changed. |
Contributor
|
@gianm yeah, I wasn't sure if this one or the backport should get the release notes. |
Contributor
|
@leventov @drcrallen why did we decide to remove |
Contributor
|
@himanshug |
Contributor
|
@gianm ah sorry, looked more carefully now, false alarm. |
himanshug
added a commit
to himanshug/druid
that referenced
this pull request
Oct 11, 2017
)" This reverts commit d8b3bfa.
himanshug
added a commit
to himanshug/druid
that referenced
this pull request
Oct 17, 2017
)" This reverts commit d8b3bfa.
cheddar
pushed a commit
that referenced
this pull request
Oct 19, 2017
…4966) * introducing CuratorLoadQueuePeon * HttpLoadQueuePeon based off of current code * Revert "Remove SegmentLoaderConfig.numLoadingThreads config (#4829)" This reverts commit d8b3bfa. * SegmentLoadDropHandler copy/pasted from ZkCoordinator * Revert "1-based counts in ZkCoordinator (#4917)" This reverts commit e725ff4. * remove non-zk part from ZkCoordinator * remove zk part from SegmentLoadDropHandler * additional changes for segment load/drop management with http * address review comments * add some more logs * Execs class is moved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4421