Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions docs/content/configuration/historical.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ The historical node uses several of the global configs in [Configuration](../con
|`druid.segmentCache.dropSegmentDelayMillis`|How long a node delays before completely dropping segment.|30000 (30 seconds)|
|`druid.segmentCache.infoDir`|Historical nodes keep track of the segments they are serving so that when the process is restarted they can reload the same segments without waiting for the Coordinator to reassign. This path defines where this metadata is kept. Directory will be created if needed.|${first_location}/info_dir|
|`druid.segmentCache.announceIntervalMillis`|How frequently to announce segments while segments are loading from cache. Set this value to zero to wait for all segments to be loaded before announcing.|5000 (5 seconds)|
|`druid.segmentCache.numLoadingThreads`|How many segments to load concurrently from from deep storage.|1|
|`druid.segmentCache.numBootstrapThreads`|How many segments to load concurrently from local storage at startup.|Same as numLoadingThreads|
|`druid.segmentCache.numBootstrapThreads`|How many segments to load concurrently from local storage at startup.|1|

### Query Configs

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
*/
public class SegmentLoaderConfig
{
private static final int DEFAULT_NUM_BOOTSTRAP_THREADS = 1;

@JsonProperty
@NotEmpty
private List<StorageLocationConfig> locations = null;
Expand All @@ -44,9 +46,6 @@ public class SegmentLoaderConfig
@JsonProperty("announceIntervalMillis")
private int announceIntervalMillis = 0; // do not background announce

@JsonProperty("numLoadingThreads")
private int numLoadingThreads = 1;

@JsonProperty("numBootstrapThreads")
private Integer numBootstrapThreads = null;

Expand All @@ -73,14 +72,9 @@ public int getAnnounceIntervalMillis()
return announceIntervalMillis;
}

public int getNumLoadingThreads()
{
return numLoadingThreads;
}

public int getNumBootstrapThreads()
{
return numBootstrapThreads == null ? numLoadingThreads : numBootstrapThreads;
return numBootstrapThreads == null ? DEFAULT_NUM_BOOTSTRAP_THREADS : numBootstrapThreads;
}

public File getInfoDir()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public void start() throws IOException
loadQueueLocation,
true,
true,
Execs.multiThreaded(config.getNumLoadingThreads(), "ZkCoordinator-%s")
Execs.singleThreaded("ZkCoordinator-%s")
);

try {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -202,12 +202,6 @@ public File getInfoDir()
return infoDir;
}

@Override
public int getNumLoadingThreads()
{
return 5;
}

@Override
public int getAnnounceIntervalMillis()
{
Expand Down Expand Up @@ -493,12 +487,6 @@ public File getInfoDir()
return infoDir;
}

@Override
public int getNumLoadingThreads()
{
return 5;
}

@Override
public int getAnnounceIntervalMillis()
{
Expand Down