warn if topic not found#4834
Merged
jihoonson merged 1 commit intoapache:masterfrom Sep 25, 2017
pjain1:kafka_log
Merged
Conversation
Contributor
|
👍 |
jihoonson
reviewed
Sep 22, 2017
Contributor
There was a problem hiding this comment.
How about moving this logging to after https://github.com/druid-io/druid/pull/4834/files#diff-6eee87b3aa4eb3a516965fe6e93e25a4R778? The check on topics.containsKey() can be changed to null check on partitions.
Member
Author
There was a problem hiding this comment.
changed...however I am curious why it is better than this ?
Contributor
There was a problem hiding this comment.
Thanks. It's very trivial, but I think it's better to read because the existence check on topic is done in one place.
jihoonson
approved these changes
Sep 25, 2017
gianm
pushed a commit
to gianm/druid
that referenced
this pull request
Sep 26, 2017
jon-wei
pushed a commit
that referenced
this pull request
Sep 26, 2017
seoeun25
added a commit
to seoeun25/incubator-druid
that referenced
this pull request
Jan 10, 2020
* Refactoring Appendertor Driver (apache#4292) * Rename FiniteAppenderatorDriver to AppenderatorDriver (apache#4356) * Add totalRowCount to appenderator * add localhost as advertised hostname (apache#4689) * kafkaIndexTask unannounce service in final block (apache#4736) * warn if topic not found (apache#4834) * Kafka: Fixes needlessly low interpretation of maxRowsInMemory. (apache#5034)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.