greater-than/less-than/equal-to havingSpec to call AggregatorFactory.finalizeComputation(..)#4883
Merged
gianm merged 5 commits intoapache:masterfrom Oct 16, 2017
Merged
Conversation
Contributor
Author
|
its failing tests in GroupByQueryRunnerTest which expect exceptions with having clause on complex metrics, will fix those once the solution proposed here is in agreement. |
Contributor
Author
|
just noticed #2507 , that should be fixed with this patch. |
Contributor
|
@himanshug could you please fix the conflict, and then feel free to merge yourself. |
gianm
added a commit
to gianm/druid
that referenced
this pull request
Oct 31, 2017
- Uses the technique from apache#4883 on DimFilterHavingSpec too. - Also uses Transformers from apache#4890, necessitating a move of that and other related classes from druid-server to druid-processing. They probably make more sense there anyway. - Adds a SQL query test. Fixes apache#4957.
fjy
pushed a commit
that referenced
this pull request
Nov 1, 2017
* Fix havingSpec on complex aggregators. - Uses the technique from #4883 on DimFilterHavingSpec too. - Also uses Transformers from #4890, necessitating a move of that and other related classes from druid-server to druid-processing. They probably make more sense there anyway. - Adds a SQL query test. Fixes #4957. * Remove unused import.
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Nov 15, 2017
…finalizeComputation(..) (apache#4883) * greater-than/less-than/equal-to havingSpec to call AggregatorFactory.finalizeComputation(..) * fix the unit test and expect having to work on hyperUnique agg * test fix * fix style errors
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Nov 15, 2017
* Fix havingSpec on complex aggregators. - Uses the technique from apache#4883 on DimFilterHavingSpec too. - Also uses Transformers from apache#4890, necessitating a move of that and other related classes from druid-server to druid-processing. They probably make more sense there anyway. - Adds a SQL query test. Fixes apache#4957. * Remove unused import.
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Dec 6, 2017
…finalizeComputation(..) (apache#4883) * greater-than/less-than/equal-to havingSpec to call AggregatorFactory.finalizeComputation(..) * fix the unit test and expect having to work on hyperUnique agg * test fix * fix style errors
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Dec 6, 2017
* Fix havingSpec on complex aggregators. - Uses the technique from apache#4883 on DimFilterHavingSpec too. - Also uses Transformers from apache#4890, necessitating a move of that and other related classes from druid-server to druid-processing. They probably make more sense there anyway. - Adds a SQL query test. Fixes apache#4957. * Remove unused import.
gianm
added a commit
to gianm/druid
that referenced
this pull request
Feb 6, 2018
Fixes two things: 1. An improper double-to-long cast when comparing double metrics to any kind of value, which was a regression from apache#4883. 2. An improper double-to-long cast when comparing a long/int metric to a double/float value: the value was cast to long/int, drawing strange conclusions like int 100 matching a havingSpec of equalTo(100.5).
gianm
added a commit
that referenced
this pull request
Feb 6, 2018
* Fix two improper casts in HavingSpecMetricComparator. Fixes two things: 1. An improper double-to-long cast when comparing double metrics to any kind of value, which was a regression from #4883. 2. An improper double-to-long cast when comparing a long/int metric to a double/float value: the value was cast to long/int, drawing strange conclusions like int 100 matching a havingSpec of equalTo(100.5). * Add comments. * Remove extraneous comment. * Simplify code a bit.
gianm
added a commit
to gianm/druid
that referenced
this pull request
Feb 6, 2018
* Fix two improper casts in HavingSpecMetricComparator. Fixes two things: 1. An improper double-to-long cast when comparing double metrics to any kind of value, which was a regression from apache#4883. 2. An improper double-to-long cast when comparing a long/int metric to a double/float value: the value was cast to long/int, drawing strange conclusions like int 100 matching a havingSpec of equalTo(100.5). * Add comments. * Remove extraneous comment. * Simplify code a bit.
jon-wei
pushed a commit
that referenced
this pull request
Feb 7, 2018
* Fix two improper casts in HavingSpecMetricComparator. Fixes two things: 1. An improper double-to-long cast when comparing double metrics to any kind of value, which was a regression from #4883. 2. An improper double-to-long cast when comparing a long/int metric to a double/float value: the value was cast to long/int, drawing strange conclusions like int 100 matching a havingSpec of equalTo(100.5). * Add comments. * Remove extraneous comment. * Simplify code a bit.
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Feb 7, 2018
* Fix two improper casts in HavingSpecMetricComparator. Fixes two things: 1. An improper double-to-long cast when comparing double metrics to any kind of value, which was a regression from apache#4883. 2. An improper double-to-long cast when comparing a long/int metric to a double/float value: the value was cast to long/int, drawing strange conclusions like int 100 matching a havingSpec of equalTo(100.5). * Add comments. * Remove extraneous comment. * Simplify code a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4859 and #2507