Only consider loaded replicants when computing replication status.#4921
Merged
gianm merged 3 commits intoapache:masterfrom Oct 18, 2017
Merged
Only consider loaded replicants when computing replication status.#4921gianm merged 3 commits intoapache:masterfrom
gianm merged 3 commits intoapache:masterfrom
Conversation
This affects the computation of segment/underReplicated/count and segment/unavailable/count, as well as the loadstatus?simple and loadstatus?full APIs. I'm not sure why they currently consider segments in the load queues, but it would make more sense to me if they only considered segments that are actually loaded.
Contributor
|
👍 |
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Oct 30, 2017
…pache#4921) * Only consider loaded replicants when computing replication status. This affects the computation of segment/underReplicated/count and segment/unavailable/count, as well as the loadstatus?simple and loadstatus?full APIs. I'm not sure why they currently consider segments in the load queues, but it would make more sense to me if they only considered segments that are actually loaded. * Fix tests. * Fix imports.
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Nov 14, 2017
…pache#4921) * Only consider loaded replicants when computing replication status. This affects the computation of segment/underReplicated/count and segment/unavailable/count, as well as the loadstatus?simple and loadstatus?full APIs. I'm not sure why they currently consider segments in the load queues, but it would make more sense to me if they only considered segments that are actually loaded. * Fix tests. * Fix imports.
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Dec 5, 2017
…pache#4921) * Only consider loaded replicants when computing replication status. This affects the computation of segment/underReplicated/count and segment/unavailable/count, as well as the loadstatus?simple and loadstatus?full APIs. I'm not sure why they currently consider segments in the load queues, but it would make more sense to me if they only considered segments that are actually loaded. * Fix tests. * Fix imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This affects the computation of segment/underReplicated/count and
segment/unavailable/count, as well as the loadstatus?simple and
loadstatus?full APIs.
I'm not sure why they currently consider segments in the load
queues, but it would make more sense to me if they only considered
segments that are actually loaded.