Remove unused limitFn in GroupByQuery#4935
Merged
gianm merged 2 commits intoapache:masterfrom Oct 10, 2017
Merged
Conversation
Member
|
This field is assigned in constructor, and there is non-trivial logic to compute the value for it. |
c91dd1f to
2483e53
Compare
Member
Contributor
Author
|
Looks like that block was reintroduced by #3873 as part of a bad merge that restored some code that was removed by https://github.com/druid-io/druid/pull/4131/files#diff-7564ae1186b5d71c461ade89580058d3. The limitFn and postProcFn it sets are not being used by anything so the block should be removed entirely. The equivalent logic is now in |
leventov
approved these changes
Oct 10, 2017
gianm
approved these changes
Oct 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the unused limitFn in GroupByQuery, as noted here: #3873 (review)