Skip to content

Fix CachingCostBalancerStrategyFactory's constructor#4974

Merged
leventov merged 3 commits intoapache:masterfrom
metamx:CachingCostBalancerStrategyFactory-bug
Oct 18, 2017
Merged

Fix CachingCostBalancerStrategyFactory's constructor#4974
leventov merged 3 commits intoapache:masterfrom
metamx:CachingCostBalancerStrategyFactory-bug

Conversation

@leventov
Copy link
Copy Markdown
Member

No description provided.

@leventov leventov removed the WIP label Oct 18, 2017
Copy link
Copy Markdown
Contributor

@gianm gianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 after CI

@gianm
Copy link
Copy Markdown
Contributor

gianm commented Oct 18, 2017

@leventov does this need to be included in 0.11.0? (you have marked it as such but I don't see a reason why in the PR description)

@leventov
Copy link
Copy Markdown
Member Author

@gianm it's a bug that makes cachingCost balancer strategy absolutely dysfunctional. BTW all users are encouraged to try cachingCost in production in 0.11.0 because the plan is that it's going to become the default balancer strategy in the next release. It's going to replace cost, i. e. cost and cachingCost will mean the same.

@gianm
Copy link
Copy Markdown
Contributor

gianm commented Oct 18, 2017

Thanks for the explanation. Let's then also make sure that the encouragement to try out cachingCost makes it into the release notes for 0.11.0. I'll mark this issue as "Release notes" as a reminder.

@leventov
Copy link
Copy Markdown
Member Author

@gianm better #4731 because it has explanations

@himanshug
Copy link
Copy Markdown
Contributor

👍

@leventov leventov merged commit 26b87c9 into apache:master Oct 18, 2017
@leventov leventov deleted the CachingCostBalancerStrategyFactory-bug branch October 18, 2017 21:21
leventov added a commit to metamx/druid that referenced this pull request Oct 18, 2017
* Fix CachingCostBalancerStrategyFactory's constructor

* Fix CachingCostBalancerStrategyFactory not registered in Lifecycle
jon-wei pushed a commit that referenced this pull request Oct 18, 2017
* Fix CachingCostBalancerStrategyFactory's constructor

* Fix CachingCostBalancerStrategyFactory not registered in Lifecycle
gianm pushed a commit to implydata/druid-public that referenced this pull request Oct 20, 2017
…pache#4981)

* Fix CachingCostBalancerStrategyFactory's constructor

* Fix CachingCostBalancerStrategyFactory not registered in Lifecycle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants