[Backport] Fix improper handling of empty arrays in StringDimensionIndexer. #5019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…che#5012) * Fix improper handling of empty arrays in StringDimensionIndexer. This bug was able to introduce data errors: if the input rows to an IncrementalIndex contained entirely empty arrays and single values, then upon persisting to disk, the empty arrays would be replaced with the lexicographically smallest single value, rather than nulls like they should have been. * Style fix. * Add tests for bitmap indexes too.
leventov
pushed a commit
to metamx/druid
that referenced
this pull request
Nov 13, 2017
…che#5012) (apache#5019) * Fix improper handling of empty arrays in StringDimensionIndexer. This bug was able to introduce data errors: if the input rows to an IncrementalIndex contained entirely empty arrays and single values, then upon persisting to disk, the empty arrays would be replaced with the lexicographically smallest single value, rather than nulls like they should have been. * Style fix. * Add tests for bitmap indexes too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5012 to 0.11.0.