[Backport] Kafka: Fixes needlessly low interpretation of maxRowsInMemory.#5036
Merged
jihoonson merged 1 commit intoapache:0.11.0from Nov 3, 2017
Merged
[Backport] Kafka: Fixes needlessly low interpretation of maxRowsInMemory.#5036jihoonson merged 1 commit intoapache:0.11.0from
jihoonson merged 1 commit intoapache:0.11.0from
Conversation
…e#5034) AppenderatorImpl already applies maxRowsInMemory across all sinks. So dividing by the number of Kafka partitions is pointless and effectively makes the interpretation of maxRowsInMemory lower than expected. This undoes one of the two changes from apache#3284, which fixed the original bug twice. In this, that's worse than fixing it once.
drcrallen
approved these changes
Nov 2, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #5034 to 0.11.0.