Downgrade Netty version 4.1 -> 4.0 #5059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
|
@leventov should we backport this? |
Member
Author
|
If it passes tests... |
Member
Author
|
@b-slim @himanshug @drcrallen could you please review this PR? |
Contributor
|
👍 after testing |
Contributor
|
@leventov not sure why this PR has a design review tag? seems to me we are reverting to the known working version of Netty. |
Contributor
|
LGTM. |
Contributor
|
👍 |
gianm
pushed a commit
to gianm/druid
that referenced
this pull request
Nov 9, 2017
gianm
added a commit
that referenced
this pull request
Nov 10, 2017
leventov
pushed a commit
to metamx/druid
that referenced
this pull request
Nov 13, 2017
anwar6953
added a commit
to cdapio/cdap
that referenced
this pull request
Apr 2, 2018
anwar6953
added a commit
to cdapio/cdap
that referenced
this pull request
Apr 4, 2018
anwar6953
added a commit
to cdapio/cdap
that referenced
this pull request
Apr 5, 2018
anwar6953
added a commit
to cdapio/cdap
that referenced
this pull request
Apr 11, 2018
Merged
adityadivami
pushed a commit
to gopaldivami/cdap-ui-forked
that referenced
this pull request
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of #4390 and the problems with client: #4973 (comment), I agree now that it's better to downgrade, as was suggested here: #4390 (comment)