make AsyncHttpCLient instance timer thread daemon #5076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianm
approved these changes
Nov 11, 2017
Contributor
gianm
left a comment
gianm
left a comment
There was a problem hiding this comment.
👍 thanks for tracking it down @himanshug
Member
|
may be backport ? |
himanshug
added a commit
to himanshug/druid
that referenced
this pull request
Nov 13, 2017
leventov
pushed a commit
to metamx/druid
that referenced
this pull request
Nov 13, 2017
gianm
pushed a commit
that referenced
this pull request
Nov 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately #5057 did not solve the problem mentioned in #4973 (comment) .
I did some more investigation and found that non-daemon thread actually comes from https://github.com/AsyncHttpClient/async-http-client/blob/async-http-client-project-2.0.37/client/src/main/java/org/asynchttpclient/DefaultAsyncHttpClient.java#L93 .
this patch overrides that timer to be exactly same except for using daemon threads. I tested it on my dev environment and problem appears to be solved.
For example, when I run druid code without this patch with Http emitter enabled, then I can see (in thread dump) non-daemon thread with name similar to "pool-39-thread-1" and with this patch those don't exist and I see daemon threads with name like "HttpPostEmitter-AsyncHttpClient-Timer-0" instead .
I'll test it more on some environments, but I think this fixed the issue.