Skip to content

Add IndexedInts.debugToString() and AbstractIndex.toString(); Add Sequence.toList() and limit()#5175

Merged
jihoonson merged 2 commits intoapache:masterfrom
metamx:some-toString
Jan 4, 2018
Merged

Add IndexedInts.debugToString() and AbstractIndex.toString(); Add Sequence.toList() and limit()#5175
jihoonson merged 2 commits intoapache:masterfrom
metamx:some-toString

Conversation

@leventov
Copy link
Copy Markdown
Member

  • Added IndexedInts.debugToString(). Configure your IDE to render IndexedInts impls using this method during debug.
  • Added toString() to QueryableIndex and IncrementalIndex via AbstractIndex

Unrelated:

  • Added Sequence.toList() and limit(), simplify code.

@jihoonson jihoonson merged commit 579f9fb into apache:master Jan 4, 2018
@leventov leventov deleted the some-toString branch January 10, 2018 16:24
@pjain1
Copy link
Copy Markdown
Member

pjain1 commented Jan 12, 2018

@leventov This PR breaks indexing tasks, toString() method in the AbstractIndex causes indexing tasks to log all the events present in the index every time incremental persists happens - https://github.com/druid-io/druid/blob/master/server/src/main/java/io/druid/segment/realtime/appenderator/AppenderatorImpl.java#L1156 ultimately causing them to fail with out of memory conditions.

@dclim dclim added this to the 0.13.0 milestone Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants