Skip to content

Remove Aggregator.reset()#5177

Merged
b-slim merged 1 commit intoapache:masterfrom
metamx:remove-aggregator-reset
Dec 19, 2017
Merged

Remove Aggregator.reset()#5177
b-slim merged 1 commit intoapache:masterfrom
metamx:remove-aggregator-reset

Conversation

@leventov
Copy link
Copy Markdown
Member

This method was scheduled for removal in Druid 0.12.

@b-slim
Copy link
Copy Markdown
Contributor

b-slim commented Dec 19, 2017

@leventov can you please add the motivation of this PR?

@leventov
Copy link
Copy Markdown
Member Author

@b-slim I don't know what to add to the PR description, this is the motivation.

Copy link
Copy Markdown
Contributor

@gianm gianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 after ci

@b-slim
Copy link
Copy Markdown
Contributor

b-slim commented Dec 19, 2017

@leventov it can be as simple as since it is deprecated and unused....

@b-slim b-slim merged commit f18eba5 into apache:master Dec 19, 2017
@leventov leventov deleted the remove-aggregator-reset branch December 19, 2017 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants