Throw away rows with timestamps beyond long bounds in kafka indexing#5215
Merged
himanshug merged 2 commits intoapache:masterfrom Jan 8, 2018
Merged
Throw away rows with timestamps beyond long bounds in kafka indexing#5215himanshug merged 2 commits intoapache:masterfrom
himanshug merged 2 commits intoapache:masterfrom
Conversation
jihoonson
reviewed
Jan 5, 2018
| && ioConfig.getMaximumMessageTime().get().isBefore(row.getTimestamp()); | ||
|
|
||
| if (!Intervals.ETERNITY.contains(row.getTimestamp())) { | ||
| log.error("Encountered row with timestamp that cannot be represented as a long: [%s]", row); |
Contributor
There was a problem hiding this comment.
This probably emits too many logs?
Contributor
Author
There was a problem hiding this comment.
changed this to log.debug instead
| if (!Intervals.ETERNITY.contains(row.getTimestamp())) { | ||
| log.error("Encountered row with timestamp that cannot be represented as a long: [%s]", row); | ||
| return false; | ||
| } |
Member
There was a problem hiding this comment.
how about reporting it as ParseException in case user has set reportParseExceptions to true ?
Contributor
Author
There was a problem hiding this comment.
changed this to throw a ParseException if reportParseExceptions is true
himanshug
approved these changes
Jan 5, 2018
jihoonson
approved these changes
Jan 6, 2018
jon-wei
added a commit
to jon-wei/druid
that referenced
this pull request
Jan 8, 2018
…pache#5215) * Throw away rows with timestamps beyond long bounds in kafka indexing * PR comments
seoeun25
added a commit
to seoeun25/incubator-druid
that referenced
this pull request
Jan 10, 2020
* Kafka Index Task that supports Incremental handoffs apache#4815 * prevent NPE from supressing actual exception (apache#5146) * prevent npe on mismatch between number of kafka partitions and task count (apache#5139) * Throw away rows with timestamps beyond long bounds in kafka indexing (apache#5215) (apache#5232) * Fix state check bug in Kafka Index Task (apache#5204) (apache#5248)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4485