Fix APPROX_QUANTILE on outer groupBys.#5253
Merged
fjy merged 1 commit intoapache:masterfrom Jan 12, 2018
Merged
Conversation
gianm
added a commit
to gianm/druid
that referenced
this pull request
Jan 12, 2018
jon-wei
pushed a commit
that referenced
this pull request
Jan 12, 2018
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Jan 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calcite evaluates a possible plan where the literal probability is pushed down to the inner query, transforming it into not-a-literal. This caused an assertion error in
RexLiteral.value(probabilityArg). This patch returns null here, skipping that possible plan and moving on to the next one where the literal is not pushed down (and the query works fine).