add LookupExtractorFactory.destroy() method#5287
Merged
gianm merged 2 commits intoapache:masterfrom Feb 2, 2018
Merged
Conversation
himanshug
force-pushed
the
lookups_destroy
branch
from
596865e to
0f7cfa9
Compare
drcrallen
approved these changes
Feb 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
many custom lookup extensions when started keep thread-pools and also persist caches on disk for fast restart of historicals.
when historical process is stopped , thread-pools etc should be properly closed but persisted cache should be left untouched on disk.
when historical is asked to drop the lookup, thread-pools etc should be properly closed and also persisted cache should be removed from the disk.
it requires additional method on LookupExtractorFactory to tell the extension writer when they are simply supposed to let go off transient resources in process memory vs when lookup is being dropped and everything (including persistent information) relevant should be deleted.
this PR is completely backward compatible.