Switch to using aws-java-sdk-bundle dependency#5288
Closed
samarthjain wants to merge 3 commits intoapache:masterfrom
Closed
Switch to using aws-java-sdk-bundle dependency#5288samarthjain wants to merge 3 commits intoapache:masterfrom
samarthjain wants to merge 3 commits intoapache:masterfrom
Conversation
…wer version of aws-sdk
leventov
reviewed
Jan 24, 2018
| <properties> | ||
| <jackson.version>2.6.5</jackson.version> | ||
| <aws.sdk.version>1.11.143</aws.sdk.version> | ||
| <aws.java.sdk.bundle.version>1.11.143</aws.java.sdk.bundle.version> |
| Need to update Druid to use Jackson 2.6+ --> | ||
| <aws.sdk.version>1.10.77</aws.sdk.version> | ||
| <!-- Use aws-sdk bundle to let druid use newer version of aws-sdk and handle dependency conflict with Jackson --> | ||
| <aws.java.sdk.bundle.version>1.11.143</aws.java.sdk.bundle.version> |
Member
There was a problem hiding this comment.
Not needed to extract this as a property, because it's used just at one place
Member
|
@samarthjain thanks for contribution, please sign CLA: http://druid.io/community/cla.html |
Contributor
|
Hi @samarthjain, I'm working on #5382 which includes some parts of this patch, and I think it's almost done. Do you think this PR is still needed? |
…using newer version of aws-sdk" This reverts commit 5b63198.
Contributor
Author
|
@jihoonson - I am closing this pull request for now. |
Contributor
|
Ok, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS provides bundled java-sdk dependency (https://aws.amazon.com/blogs/developer/java-sdk-bundle/) which shades jackson and other dependencies that was preventing druid from upgrading from 1.10.* version of aws-sdk. This pull request causes druid to now use this bundle as a dependency.