fix RemoteTaskRunner terminating lazy workers below autoscaler minNumWorkers value#5310
Merged
leventov merged 2 commits intoapache:masterfrom Feb 1, 2018
Merged
Conversation
leventov
reviewed
Jan 31, 2018
| @Override | ||
| public Collection<Worker> markWorkersLazy(Predicate<ImmutableWorkerInfo> isLazyWorker, int maxWorkers) | ||
| { | ||
| if (maxWorkers < 1) { |
leventov
approved these changes
Jan 31, 2018
gianm
pushed a commit
to gianm/druid
that referenced
this pull request
Feb 2, 2018
…Workers value (apache#5310) * fix RemoteTaskRunner terminating lazy workers below autoscaler minNumWorkers value * add comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
markWorkersLazymethod ofRemoteTaskRunnerwill incorrectly mark all lazy workers as lazy when themaxWorkersparameter is 0. This is the case where current workers are lazy, yet required to satisfy the autoscalerminNumWorkerssetting, which results in all lazy workers being killed every idle timeout, and replaced immediately, indefinitely or until at leastminNumWorkersare no longer considered lazy.