Debug logging in HttpPostEmitter and Batch#5365
Merged
pjain1 merged 1 commit intoapache:masterfrom Feb 13, 2018
Merged
Conversation
Contributor
|
👍 |
Member
Author
|
@pjain1 could you please review and merge this if it is ok? |
gianm
pushed a commit
to gianm/druid
that referenced
this pull request
Feb 15, 2018
pjain1
pushed a commit
that referenced
this pull request
Feb 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addition should help to debug #5338, but it could also remain in the source code, because normally debug logging is not enabled.
@pjain1 @niketh @himanshug
Setup logging so that debug logging is enabled only in
io.druid.java.util.emitter.corepackage, or just inHttpPostEmitterandBatchclasses.Setup logging so that the thread name is printed.