Support for router forwarding requests to active coordinator/overlord#5369
Merged
jon-wei merged 4 commits intoapache:masterfrom Feb 15, 2018
dclim:router-management-proxy
Merged
Support for router forwarding requests to active coordinator/overlord#5369jon-wei merged 4 commits intoapache:masterfrom dclim:router-management-proxy
jon-wei merged 4 commits intoapache:masterfrom
dclim:router-management-proxy
Conversation
himanshug
approved these changes
Feb 8, 2018
Member
|
have not reviewed the code changes yet, |
Contributor
Author
|
@nishantmonu51 interesting, I didn't consider that and I'm fairly sure it won't work right now. We can consider adding support for this if it's a requested feature, but I think it makes sense to implement that in a different PR since it'll be pretty different from forwarding API calls (the router may need to serve the js/css/img resources files, it may need to rewrite the URLs in the HTML, etc.) |
jihoonson
approved these changes
Feb 15, 2018
| MODIFIED_PATH_ATTRIBUTE, request.getRequestURI().substring(ARBITRARY_OVERLORD_BASE_PATH.length()) | ||
| ); | ||
| } else { | ||
| handleBadRequest(response, "Unsupported proxy destination"); |
Contributor
There was a problem hiding this comment.
Would be nice if the error message shows the wrong URI.
jon-wei
approved these changes
Feb 15, 2018
jon-wei
pushed a commit
to implydata/druid-public
that referenced
this pull request
Feb 15, 2018
…apache#5369) * allow router to forward requests to coordinator and overlord * fix forbidden API * more forbidden api fixes * code review changes
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Mar 12, 2018
…apache#5369) * allow router to forward requests to coordinator and overlord * fix forbidden API * more forbidden api fixes * code review changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the router to be configured to proxy requests to the active coordinator or overlord. This is different from the current inactive->active HTTP redirect behavior which has a number of shortcomings and does not work well with some deployment architectures.
The default behavior is for the management proxy to be disabled. See router.md for more information on the routing behavior.
Supports TLS and security. Authentication gets checked on the router (as well as destination), and authorization is checked on the destination (similar to how the query forwarding functions).