Automatically adjust com.metamx.metrics Monitor class references#5412
Merged
jon-wei merged 2 commits intoapache:masterfrom Feb 22, 2018
Merged
Automatically adjust com.metamx.metrics Monitor class references#5412jon-wei merged 2 commits intoapache:masterfrom
jon-wei merged 2 commits intoapache:masterfrom
Conversation
jihoonson
reviewed
Feb 22, 2018
| } | ||
| try { | ||
| for (String monitorName : monitorNames) { | ||
| String effectiveMonitorName = monitorName.replace(OLD_METAMX_PACKAGE_NAME, NEW_DRUID_PACKAGE_NAME); |
Contributor
There was a problem hiding this comment.
How about logging a warning to use the new name instead of the old one?
jihoonson
approved these changes
Feb 22, 2018
jon-wei
added a commit
to jon-wei/druid
that referenced
this pull request
Feb 22, 2018
…che#5412) * Automatically adjust com.metamx.metrics monitor class references * Log warning for old class names
jon-wei
added a commit
that referenced
this pull request
Feb 23, 2018
…) (#5417) * Automatically adjust com.metamx.metrics monitor class references * Log warning for old class names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR automatically converts Monitor class names with
com.metamx.metricsto useio.druid.java.util.metricsinstead (See #5289).This will make 0.12.0 upgrades easier for anyone who was using a Monitor from the metamx java-util package.
Adding this to 0.12.0 milestone as it helps with configuration backwards compatibility.