Enforce optimal IndexedInts iteration#5456
Merged
gianm merged 2 commits intoapache:masterfrom Mar 9, 2018
Merged
Conversation
gianm
approved these changes
Mar 3, 2018
Contributor
gianm
left a comment
gianm
left a comment
There was a problem hiding this comment.
LGTM. I am not totally sure if the java compiler or JVM is able to figure out that the sizes are constants and do this transformation on its own. But the source still looks fine with manual transformation so why not.
Member
Author
|
@gianm could you please merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IndexedIntsare usually iterated in some other loop, i. e. it's a nested, not a top level loop. So it should pay off to carefully write those loops.