SQL: Fix precision of TIMESTAMP types.#5464
Merged
fjy merged 1 commit intoapache:masterfrom Mar 6, 2018
Merged
Conversation
Druid stores timestamps down to the millisecond, so we should use precision = 3. Setting this wrong sometimes caused milliseconds to be ignored in timestamp literals. Fixes apache#5337.
Contributor
|
👍 |
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Apr 10, 2018
Druid stores timestamps down to the millisecond, so we should use precision = 3. Setting this wrong sometimes caused milliseconds to be ignored in timestamp literals. Fixes apache#5337.
gianm
added a commit
to gianm/druid
that referenced
this pull request
Aug 27, 2018
Druid stores timestamps down to the millisecond, so we should use precision = 3. Setting this wrong sometimes caused milliseconds to be ignored in timestamp literals. Fixes apache#5337.
fjy
pushed a commit
that referenced
this pull request
Aug 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Druid stores timestamps down to the millisecond, so we should use
precision = 3. Setting this wrong sometimes caused milliseconds
to be ignored in timestamp literals.
The patch moves type creation to a utility method and fixes the
precision there.
Fixes #5337.