Merge druid-api, druid-common and java-util modules into druid-common; Replace EmittedBatchCounter and UpdateCounter with ConcurrentAwaitableCounter#5488
Closed
leventov wants to merge 2 commits intoapache:masterfrom
Conversation
…; Replace EmittedBatchCounter and UpdateCounter with (both not safe for concurrent increments/updates) with ConcurrentAwaitableCounter (safe for concurrent increments)
This was referenced Mar 14, 2018
Contributor
|
I know it is more of a pain, but I think it'd be nice to do this as two patches, one for the combine and one for the bug fix. It will make the git history more readable. Not to mention, the review of the bugfix will be more readable. I think the combining of those modules makes total sense at this point. |
Contributor
|
@leventov can we do this in 2 different PRs? like that we can revert if needed, sorry for extra work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EmittedBatchCounter and UpdateCounter are both not safe for concurrent increments/updates. ConcurrentAwaitableCounter is safe for concurrent increments.
Fixes #5485. I had to collapse druid-api, druid-common and java-util, to avoid cyclic dependencies. It was a part of #4312 plan.