Replace EmittedBatchCounter and UpdateCounter with ConcurrentAwaitableCounter#5592
Merged
gianm merged 4 commits intoapache:masterfrom Apr 13, 2018
Merged
Conversation
… concurrent increments/updates) with ConcurrentAwaitableCounter (safe for concurrent increments)
leventov
force-pushed
the
concurrent-awaitable-counter-2
branch
from
15f572f to
37537b6
Compare
Member
Author
|
This PR is ready for review. |
clintropolis
approved these changes
Apr 9, 2018
| { | ||
| private static final long MAX_COUNT = Long.MAX_VALUE; | ||
|
|
||
| public static long nextCount(long prevCount) |
| } | ||
| } | ||
|
|
||
| public void awaitCount(long totalCount, long timeout, TimeUnit unit) throws InterruptedException, TimeoutException |
…t instead of masking errors
Contributor
|
@leventov will you do the backport or shall I? |
Member
Author
|
@gianm could you please backport? |
gianm
pushed a commit
to gianm/druid
that referenced
this pull request
Apr 13, 2018
…eCounter (apache#5592) * Replace EmittedBatchCounter and UpdateCounter with (both not safe for concurrent increments/updates) with ConcurrentAwaitableCounter (safe for concurrent increments) * Fixes * Fix EmitterTest * Added Javadoc and make awaitCount() to throw exceptions on wrong count instead of masking errors
Contributor
|
Sure: #5642 |
jon-wei
pushed a commit
that referenced
this pull request
Apr 13, 2018
…eCounter (#5592) (#5642) * Replace EmittedBatchCounter and UpdateCounter with (both not safe for concurrent increments/updates) with ConcurrentAwaitableCounter (safe for concurrent increments) * Fixes * Fix EmitterTest * Added Javadoc and make awaitCount() to throw exceptions on wrong count instead of masking errors
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Apr 16, 2018
…eCounter (apache#5592) (apache#5642) * Replace EmittedBatchCounter and UpdateCounter with (both not safe for concurrent increments/updates) with ConcurrentAwaitableCounter (safe for concurrent increments) * Fixes * Fix EmitterTest * Added Javadoc and make awaitCount() to throw exceptions on wrong count instead of masking errors
sathishsri88
pushed a commit
to sathishs/druid
that referenced
this pull request
May 8, 2018
…eCounter (apache#5592) * Replace EmittedBatchCounter and UpdateCounter with (both not safe for concurrent increments/updates) with ConcurrentAwaitableCounter (safe for concurrent increments) * Fixes * Fix EmitterTest * Added Javadoc and make awaitCount() to throw exceptions on wrong count instead of masking errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace EmittedBatchCounter and UpdateCounter with (both not safe for concurrent increments/updates) with ConcurrentAwaitableCounter (safe for concurrent increments).
Fixes #5485.