Conversation
Contributor
gianm
commented
Jan 16, 2013
gianm
commented
- Can handle non-rolled-up input (by grouping input rows using an additional MR stage)
- Can select its own partitioning dimension, if none is supplied
- Can detect and avoid oversized shards due to bad dimension value distribution
- Shares input parsing code with IndexGeneratorJob
…t legitimately overlap our input intervals
- Can handle non-rolled-up input (by grouping input rows using an additional MR stage) - Can select its own partitioning dimension, if none is supplied - Can detect and avoid oversized shards due to bad dimension value distribution - Shares input parsing code with IndexGeneratorJob
Contributor
There was a problem hiding this comment.
It's kinda weird to pull the configuration out for each and every property... Looks like that's how the code was, which was needless. Let's fix that up now and just get the configuration once.
HadoopDruidIndexerConfig: - Add partitionsSpec (backwards compatible with targetPartitionSize and partitionDimension) - Add assumeGrouped flag to partitionsSpec DeterminePartitionsJob: - Skip group-by job if assumeGrouped is set - Clean up code a bit
Conflicts: indexer/src/main/java/com/metamx/druid/indexer/IndexGeneratorJob.java
cheddar
pushed a commit
to cheddar/druid
that referenced
this pull request
Jul 1, 2015
New UT for classes RetryPolicyFactory and TaskToolbox
jon-wei
pushed a commit
to jon-wei/druid
that referenced
this pull request
Feb 13, 2020
… (apache#56) * ANY Aggregator should not skip null values implementation * add tests * add more tests * Update documentation * add more tests * address review comments * optimize StringAnyBufferAggregator * fix failing tests * address pr comments
GabrielCWT
added a commit
to GabrielCWT/druid
that referenced
this pull request
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.