Skip to content

[Backport] Add overlord unsecured paths to coordinator when using combined service #5606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjy merged 1 commit into from
Apr 10, 2018
Merged

[Backport] Add overlord unsecured paths to coordinator when using combined service #5606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions services/src/main/java/io/druid/cli/CliOverlord.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

import com.fasterxml.jackson.databind.ObjectMapper;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.Lists;
import com.google.inject.Binder;
import com.google.inject.Injector;
import com.google.inject.Key;
Expand Down Expand Up @@ -116,7 +115,7 @@ public class CliOverlord extends ServerRunnable
{
private static Logger log = new Logger(CliOverlord.class);

private static List<String> UNSECURED_PATHS = Lists.newArrayList(
protected static List<String> UNSECURED_PATHS = ImmutableList.of(
"/",
"/console.html",
"/old-console/*",
Expand Down
4 changes: 4 additions & 0 deletions services/src/main/java/io/druid/cli/CoordinatorJettyServerInitializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@ public void initialize(Server server, Injector injector)
// perform no-op authorization for these resources
AuthenticationUtils.addNoopAuthorizationFilters(root, UNSECURED_PATHS);

if (beOverlord) {
AuthenticationUtils.addNoopAuthorizationFilters(root, CliOverlord.UNSECURED_PATHS);
}

authenticators = authenticatorMapper.getAuthenticatorChain();
AuthenticationUtils.addAuthenticationFilterChain(root, authenticators);

Expand Down