ParallelCombiner: Fix buffer leak on exception in "combine".#5630
Merged
gianm merged 1 commit intoapache:masterfrom Apr 12, 2018
Merged
ParallelCombiner: Fix buffer leak on exception in "combine".#5630gianm merged 1 commit intoapache:masterfrom
gianm merged 1 commit intoapache:masterfrom
Conversation
Once a buffer is acquired, we need to make sure to release it if an exception is thrown before the closeable iterator is created.
Contributor
|
I think it makes sense to backport 0.12. |
Contributor
|
Maybe related to #5630. |
gianm
added a commit
to gianm/druid
that referenced
this pull request
Apr 12, 2018
…5630) Once a buffer is acquired, we need to make sure to release it if an exception is thrown before the closeable iterator is created.
b-slim
pushed a commit
that referenced
this pull request
Apr 12, 2018
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Apr 12, 2018
…5630) Once a buffer is acquired, we need to make sure to release it if an exception is thrown before the closeable iterator is created.
sathishsri88
pushed a commit
to sathishs/druid
that referenced
this pull request
May 8, 2018
…5630) Once a buffer is acquired, we need to make sure to release it if an exception is thrown before the closeable iterator is created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once a buffer is acquired, we need to make sure to release it if an
exception is thrown before the closeable iterator is created.
Possibly fixes #5629.