topN: Fix caching of Float dimension values.#5653
Merged
fjy merged 1 commit intoapache:masterfrom Apr 17, 2018
Merged
Conversation
Jackson would deserialize them as Doubles, leading to ClassCastExceptions in the topN processing pipeline when it attempted to treat them as Floats.
jon-wei
approved these changes
Apr 17, 2018
sathishsri88
pushed a commit
to sathishs/druid
that referenced
this pull request
May 8, 2018
Jackson would deserialize them as Doubles, leading to ClassCastExceptions in the topN processing pipeline when it attempted to treat them as Floats.
jihoonson
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jul 6, 2018
Jackson would deserialize them as Doubles, leading to ClassCastExceptions in the topN processing pipeline when it attempted to treat them as Floats.
jihoonson
added a commit
to implydata/druid-public
that referenced
this pull request
Jul 6, 2018
jihoonson
pushed a commit
to jihoonson/druid
that referenced
this pull request
Jul 6, 2018
Jackson would deserialize them as Doubles, leading to ClassCastExceptions in the topN processing pipeline when it attempted to treat them as Floats.
gianm
pushed a commit
that referenced
this pull request
Jul 9, 2018
leventov
pushed a commit
to metamx/druid
that referenced
this pull request
Jul 20, 2018
Jackson would deserialize them as Doubles, leading to ClassCastExceptions in the topN processing pipeline when it attempted to treat them as Floats.
jihoonson
reviewed
Aug 8, 2018
|
|
||
| @Test | ||
| public void testCacheStrategyWithFloatDimension() throws Exception | ||
| { |
Contributor
Author
There was a problem hiding this comment.
No, I must have included it by accident. I think it's not needed since I modified the testCacheStrategy test to check all four supported types.
Contributor
There was a problem hiding this comment.
Thanks. I'll remove this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jackson would deserialize them as Doubles, leading to ClassCastExceptions
in the topN processing pipeline when it attempted to treat them as Floats.