Skip to content

Timeseries: Epoch time instead of null for grandTotal. #5659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gianm wants to merge 1 commit into from
Closed

Timeseries: Epoch time instead of null for grandTotal. #5659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/content/querying/timeseriesquery.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,9 @@ Druid can include an extra "grand totals" row as the last row of a timeseries re
}
```

The grand totals row will appear as the last row in the result array, and will have no timestamp. It will be the last
row even if the query is run in "descending" mode. Post-aggregations in the grand totals row will be computed based
upon the grand total aggregations.
The grand totals row will appear as the last row in the result array, and will have the Unix epoch as its timestamp
(1970-01-01T00:00:00Z). It will be the last row even if the query is run in "descending" mode. Post-aggregations in
the grand totals row will be computed based upon the grand total aggregations.

#### Zero-filling

Expand Down
3 changes: 2 additions & 1 deletion processing/src/main/java/io/druid/query/timeseries/TimeseriesQueryQueryToolChest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import com.google.common.collect.Maps;
import com.google.common.collect.Ordering;
import com.google.inject.Inject;
import io.druid.java.util.common.DateTimes;
import io.druid.java.util.common.granularity.Granularity;
import io.druid.java.util.common.guava.Sequence;
import io.druid.java.util.common.guava.Sequences;
Expand Down Expand Up @@ -181,7 +182,7 @@ public Sequence<Result<TimeseriesResultValue>> run(
}

final Result<TimeseriesResultValue> result = new Result<>(
null,
DateTimes.EPOCH,
new TimeseriesResultValue(totalsMap)
);

Expand Down
2 changes: 1 addition & 1 deletion processing/src/test/java/io/druid/query/timeseries/TimeseriesQueryRunnerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ public void testTimeseriesGrandTotal()

expectedResults.add(
new Result<>(
null,
DateTimes.EPOCH,
new TimeseriesResultValue(
ImmutableMap.of(
"rows",
Expand Down