fix cache populate incorrect content when numBackgroundThreads>1 on b…#5694
Closed
kaijianding wants to merge 1 commit intoapache:masterfrom
Closed
fix cache populate incorrect content when numBackgroundThreads>1 on b…#5694kaijianding wants to merge 1 commit intoapache:masterfrom
kaijianding wants to merge 1 commit intoapache:masterfrom
Conversation
gianm
reviewed
Apr 28, 2018
Contributor
gianm
left a comment
gianm
left a comment
There was a problem hiding this comment.
Is this really a bug? In #3943 the cacheResults.add call was done in a separate thread, meaning they could be added out of order. And the fix was to instead create a list of futures, not a list of results, and add the futures in the proper order.
But in the code being changed in this patch, we already had a list of futures, and it was already in the proper order. So it doesn't look like a bug. Right?
Contributor
Author
|
my mis-understanding. it is different with what happens in #3943 now, close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…roker
it's a follow up of #3943. the same bug exists on broker side.