Fix KerberosAuthenticator serverPrincipal host replacement#5766
Merged
nishantmonu51 merged 1 commit intoapache:masterfrom May 10, 2018
Merged
Fix KerberosAuthenticator serverPrincipal host replacement#5766nishantmonu51 merged 1 commit intoapache:masterfrom
nishantmonu51 merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
👍 |
Contributor
|
@jon-wei do you have the Stack trace that lead to this issue? it is helpful to have it indexed for eventual FAQs about kerberos madness.. |
Contributor
Author
|
@b-slim I don't have a stack trace, I noticed the issue while reviewing the code |
jon-wei
added a commit
to jon-wei/druid
that referenced
this pull request
May 10, 2018
jon-wei
added a commit
that referenced
this pull request
May 11, 2018
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
May 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kerberos authenticator has a feature to replace the "_HOST" placeholder string (if present) in the serverPrincipal with the value of
druid.host.This transformation wasn't applied in getPrincipalFromRequestNew(), this patch changes serverPrincipal such that the host replacement is applied in the constructor and saved.