Skip to content

remove Kafka eight module#5841

Closed
b-slim wants to merge 1 commit intoapache:masterfrom
b-slim:move_k8_upstream
Closed

remove Kafka eight module#5841
b-slim wants to merge 1 commit intoapache:masterfrom
b-slim:move_k8_upstream

Conversation

@b-slim
Copy link
Copy Markdown
Contributor

@b-slim b-slim commented Jun 1, 2018

I think this module is not used anymore (am not sure if it was really used), it has some outdated dependencies and takes out build resources for no reason.
Am suggestion removing it.


This change is Reviewable

@b-slim b-slim added the Apache Items related to being a part of the ASF label Jun 1, 2018
@b-slim b-slim requested a review from nishantmonu51 June 1, 2018 11:12
@b-slim b-slim removed the Apache Items related to being a part of the ASF label Jun 1, 2018
@b-slim
Copy link
Copy Markdown
Contributor Author

b-slim commented Jun 1, 2018

CC @fjy

Change-Id: I7cde2327b5a015fee38cdd732580ad820cc6860c
@b-slim b-slim force-pushed the move_k8_upstream branch from ec2acc0 to 7b5674a Compare June 1, 2018 11:15
@freakyzoidberg
Copy link
Copy Markdown
Member

Hello, although we wouldn't be impacted by this removal,
We use a slightly modified version of this for Kafka 10, which I guess we could contribute back if you want.

@b-slim
Copy link
Copy Markdown
Contributor Author

b-slim commented Jun 1, 2018

@freakyzoidberg contribution is more than welcome, you want to send a PR to add your module as part of contrib modules?

Copy link
Copy Markdown
Member

@nishantmonu51 nishantmonu51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 👍

@jihoonson
Copy link
Copy Markdown
Contributor

Please check the CI failure.

@jon-wei
Copy link
Copy Markdown
Contributor

jon-wei commented Jun 15, 2018

[ERROR] Failed to execute goal on project druid-integration-tests: Could not resolve dependencies for project io.druid:druid-integration-tests:jar:0.13.0-SNAPSHOT: Could not find artifact io.druid.extensions:druid-kafka-eight:jar:0.13.0-SNAPSHOT in sonatype-snapshots (https://oss.sonatype.org/content/repositories/snapshots/) -> [Help 1]

Looks like the dependency needs to be removed from druid-integration-tests as well

@jon-wei
Copy link
Copy Markdown
Contributor

jon-wei commented Jun 15, 2018

I'm not sure if we should remove this (or maybe keep those firehose implementations in sync with the kafka version used by kafka-indexing-service, is that worth the effort?).

If we do get rid of it, we should probably also remove http://druid.io/docs/latest/development/extensions-contrib/kafka-simple.html and take out the docs for both extensions as well

@stale
Copy link
Copy Markdown

stale Bot commented Feb 28, 2019

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale Bot added the stale label Feb 28, 2019
@stale
Copy link
Copy Markdown

stale Bot commented Mar 7, 2019

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@stale stale Bot closed this Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants