Conversation
|
CC @fjy |
Change-Id: I7cde2327b5a015fee38cdd732580ad820cc6860c
|
Hello, although we wouldn't be impacted by this removal, |
|
@freakyzoidberg contribution is more than welcome, you want to send a PR to add your module as part of contrib modules? |
|
Please check the CI failure. |
Looks like the dependency needs to be removed from druid-integration-tests as well |
|
I'm not sure if we should remove this (or maybe keep those firehose implementations in sync with the kafka version used by kafka-indexing-service, is that worth the effort?). If we do get rid of it, we should probably also remove http://druid.io/docs/latest/development/extensions-contrib/kafka-simple.html and take out the docs for both extensions as well |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@druid.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
I think this module is not used anymore (am not sure if it was really used), it has some outdated dependencies and takes out build resources for no reason.
Am suggestion removing it.
This change is