Lazy-ify IncrementalIndex filtering too.#5852
Merged
jon-wei merged 2 commits intoapache:masterfrom Jun 7, 2018
Merged
Conversation
Follow-up to apache#5403, which only lazy-ified cursor-based filtering on QueryableIndex.
jon-wei
previously approved these changes
Jun 6, 2018
leventov
reviewed
Jun 6, 2018
| @Override | ||
| public ValueMatcher makeValueMatcher(final Predicate<String> predicate) | ||
| { | ||
| final BitSet predicateMatchingValueIds = DimensionSelectorUtils.makePredicateMatchingSet(this, predicate); |
Member
There was a problem hiding this comment.
Is DimensionSelectorUtils.makePredicateMatchingSet() still used or could be deleted?
Contributor
Author
There was a problem hiding this comment.
It's still used in one place: ForwardingFilteredDimensionSpec. I would like to rewrite that code to be lazy in a follow up PR, and delete DimensionSelectorUtils.makePredicateMatchingSet at that time. I didn't do it in this patch since I wanted to keep it small.
jon-wei
approved these changes
Jun 7, 2018
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Jun 7, 2018
* Lazy-ify IncrementalIndex filtering too. Follow-up to apache#5403, which only lazy-ified cursor-based filtering on QueryableIndex. * Fix logic error.
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Jun 7, 2018
* Lazy-ify IncrementalIndex filtering too. Follow-up to apache#5403, which only lazy-ified cursor-based filtering on QueryableIndex. * Fix logic error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5403, which only lazy-ified cursor-based filtering
on QueryableIndex.