Proper handling of the exceptions from auto persisting in AppenderatorImpl.add()#5932
Merged
gianm merged 1 commit intoapache:masterfrom Jul 5, 2018
Merged
Conversation
gianm
approved these changes
Jul 5, 2018
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jul 5, 2018
jihoonson
added a commit
to jihoonson/druid
that referenced
this pull request
Jul 9, 2018
jihoonson
added a commit
that referenced
this pull request
Jul 9, 2018
leventov
pushed a commit
to metamx/druid
that referenced
this pull request
Jul 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppenderatorImpl.add()can optionally callpersistAll()if needed. The actual persisting task is executed in background andpersistAll()returns aFuturefor the background task. The exceptions from thisFutureis not currently being handled properly.This change is