Synchronize scheduled poll() calls in SQLMetadataRuleManager to prevent flakiness in SqlMetadataRuleManagerTest#6033
Merged
jihoonson merged 1 commit intoapache:masterfrom Jul 24, 2018
Conversation
…nt flakiness in SqlMetadataRuleManagerTest
jihoonson
reviewed
Jul 23, 2018
| */ | ||
| private long currentStartOrder = -1; | ||
| private ScheduledExecutorService exec = null; | ||
| private long retryStartTime = 0; |
Contributor
There was a problem hiding this comment.
nit: looks that this can be a local variable.
Contributor
|
This is a regression bug and should be included in 0.12.2. |
Contributor
|
NVM. It's already tagged. |
jihoonson
pushed a commit
to jihoonson/druid
that referenced
this pull request
Jul 27, 2018
…nt flakiness in SqlMetadataRuleManagerTest (apache#6033)
jihoonson
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jul 27, 2018
…nt flakiness in SqlMetadataRuleManagerTest (apache#6033)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix #6028, however it doesn't address two other problems mentioned in that issue:
SQLMetadataRuleManagerpossibly mixing two abstractions, that should be in different classes.