Add maven.exec.xxx.skip option for exec-maven-plugin by asdf2014 · Pull Request #6162 · apache/druid

asdf2014 · 2018-08-13T06:49:32Z

Try to fix #6160

asdf2014 · 2018-08-13T09:13:16Z

It seems that those maven options are in effect. The travis job#415338345 failed again related to the test case timeout. Would you please help me to rebuild it? @jihoonson

jihoonson · 2018-08-13T20:37:31Z

@asdf2014 thanks for taking this issue. I've restarted the failed one.

BTW, IMO, it would be better to have an option to make the distribution tarball rather than avoiding pulling some dependencies. As you can see in https://github.com/apache/incubator-druid/blob/master/distribution/pom.xml, mvn install does more things other than pulling libraries to build the distribution tarball. I think we can simply skip this if some option like -Pdist is not specified. Please check Hadoop's pom.xml as an example.

asdf2014 · 2018-08-14T01:07:39Z

Hi, @jihoonson . Thanks for your help. The travis job is succeeded. Yes, using profile to control this will be better, it has been changed.

jihoonson · 2018-08-14T19:53:16Z

Thanks. Would you please add a doc for this? Probably you can add it to https://github.com/apache/incubator-druid/blob/master/docs/content/development/build.md.

Also, if you want, you can change the travis script to not make the distribution tarball, so that we can check it helps Travis jobs to succeed.

asdf2014 · 2018-08-16T03:36:20Z

@jihoonson Indeed, it is necessary to double check it. After adding the -Pdist option, it seems that I can see from the log that this option is already works, and the exec-maven-plugin plugin starts running.

jihoonson

@asdf2014 thanks! I left some more comments.

jihoonson · 2018-08-16T17:58:56Z

This profile only skips pulling dependencies. How about skipping the entire process to build the distribution tarball? I think -Pdist is more intuitive name for skipping the entire process.

Do you mean that the bundle-contrib-exts part should also be included in the dist profile? Or should we include all the build plugins, such as the maven-assembly-plugin and license-maven-plugin plugins?

I mean both. We don't have to execute assembling the tarball or downloading licenses for the install phase. Also, bundle-contrib-exts is currently not executed by default, but it should also be a part of building the distribution tarball.

Okay, i got it.

jihoonson · 2018-08-16T18:00:01Z

Would you explain how this property is being used?

Sure, we also can use -Dtar to execute this plugin. In addition, if we used both of name and value tags, then only -Dtar=dist will be in effect.

<property> <name>tar</name> <value>dist</value> </property>

Thanks. Please document this option as well.

jihoonson · 2018-08-16T18:02:13Z

We need to add more details about this option. The document should say what this option means and how different mvn clean install and mvn clean install -Pdist are. Also, please update this command to mvn clean install -Pdist

Okay, i will improve this.

jihoonson · 2018-08-21T21:13:35Z

Thanks @asdf2014. Would you check this warning which is seen when building the project.

[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for io.druid:distribution:pom:0.13.0-SNAPSHOT
[WARNING] 'profiles.profile[dist].plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.codehaus.mojo:exec-maven-plugin @ io.druid:distribution:[unknown-version], /Users/jihoonson/Codes/druid/distribution/pom.xml, line 152, column 29
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
[WARNING] The project io.druid:druid-benchmarks:jar:0.13.0-SNAPSHOT uses prerequisites which is only intended for maven-plugin projects but not for non maven-plugin projects. For such purposes you should use the maven-enforcer-plugin. See https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
...

jihoonson · 2018-08-21T21:50:43Z

How about this? https://gist.github.com/jihoonson/bffa89fd2a5f9473bb6467d3c52f12f6

Hi, @jihoonson . Sorry for the delayed reply, this has been patched, PTAL.

jihoonson · 2018-09-10T23:58:48Z

@asdf2014 sorry for the delayed review. Would you please resolve conflicts? I'll review again.

asdf2014 · 2018-09-20T06:33:28Z

Hi, @jihoonson . The conflict has been fixed. PTAL.

jihoonson

@asdf2014 thanks! Please check my last comment.

jihoonson · 2018-09-21T01:00:21Z

+                                        <argument>
+                                            -Ddruid.extensions.hadoopDependenciesDir=${project.build.directory}/hadoop-dependencies
+                                        </argument>
+                                        <argument>io.druid.cli.Main</argument>


We have changed all package names from io.druid to org.apache.druid. Please fix this.

Same for other places below.

fjy · 2018-09-25T00:53:11Z

@asdf2014 can we finish this up?

asdf2014 · 2018-09-25T02:25:43Z

Hi, @fjy . It's done. PTAL.

jihoonson

LGTM. Thanks @asdf2014!

jihoonson added the Area - Testing label Aug 13, 2018

jihoonson reviewed Aug 16, 2018

View reviewed changes

jihoonson reviewed Aug 21, 2018

View reviewed changes

Fix conflicts

042cc28

jihoonson reviewed Sep 21, 2018

View reviewed changes

jihoonson added this to the 0.13.0 milestone Sep 21, 2018

Modify io.druid into org.apache.druid

1956ae2

jihoonson approved these changes Sep 25, 2018

View reviewed changes

QiuMM approved these changes Sep 25, 2018

View reviewed changes

fjy merged commit e5d9fcf into apache:master Sep 25, 2018

asdf2014 deleted the skip_exec branch September 26, 2018 01:24

dclim mentioned this pull request Oct 19, 2018

fix distribution to not include contrib extensions by default, don't … #6494

Merged

Conversation

asdf2014 commented Aug 13, 2018

Uh oh!

asdf2014 commented Aug 13, 2018

Uh oh!

jihoonson commented Aug 13, 2018

Uh oh!

asdf2014 commented Aug 14, 2018

Uh oh!

jihoonson commented Aug 14, 2018

Uh oh!

asdf2014 commented Aug 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jihoonson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jihoonson commented Aug 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jihoonson commented Sep 10, 2018

Uh oh!

asdf2014 commented Sep 20, 2018

Uh oh!

jihoonson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fjy commented Sep 25, 2018

Uh oh!

asdf2014 commented Sep 25, 2018

Uh oh!

jihoonson left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

asdf2014 commented Aug 16, 2018 •

edited

Loading

jihoonson commented Aug 21, 2018 •

edited

Loading