SQL: Finalize aggregations for inner queries when necessary.#6221
Merged
gianm merged 2 commits intoapache:masterfrom Aug 25, 2018
Merged
SQL: Finalize aggregations for inner queries when necessary.#6221gianm merged 2 commits intoapache:masterfrom
gianm merged 2 commits intoapache:masterfrom
Conversation
nishantmonu51
approved these changes
Aug 23, 2018
| @@ -42,14 +42,14 @@ public void testEscapeStringLiteral() | |||
| @Test | |||
| public void testFindOutputNamePrefix() | |||
Member
There was a problem hiding this comment.
nit: rename test method name to testFindUnusedPrefix.
Contributor
Author
There was a problem hiding this comment.
Fixed that and re-pushed.
gianm
added a commit
to gianm/druid
that referenced
this pull request
Aug 25, 2018
…6221) * SQL: Finalize aggregations for inner queries when necessary. Fixes apache#5779. * Fixed test method name.
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Aug 25, 2018
…6221) * SQL: Finalize aggregations for inner queries when necessary. Fixes apache#5779. * Fixed test method name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5779.