[Backport] SQL: Fix post-aggregator naming logic for sort-project.#6257
Merged
fjy merged 1 commit intoapache:0.12.3from Aug 29, 2018
Merged
[Backport] SQL: Fix post-aggregator naming logic for sort-project.#6257fjy merged 1 commit intoapache:0.12.3from
fjy merged 1 commit intoapache:0.12.3from
Conversation
gianm
changed the title
gianm
changed the title
The old code assumes that post-aggregator prefixes are one character
long followed by numbers. This isn't always true (we may pad with
underscores to avoid conflicts). Instead, the new code uses a different
base prefix for sort-project postaggregators ("s" instead of "p") and
uses the usual Calcites.findUnusedPrefix function to avoid conflicts.
gianm
force-pushed
the
backport-6250-to-0.12.3
branch
from
0866700 to
d22eef8
Compare
Contributor
Author
|
Had to fix a test-- repushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #6250 to 0.12.3.