Skip to content

BytesFullResponseHandler should only consume readableBytes of ChannelBuffer#6270

Merged
jon-wei merged 1 commit intoapache:masterfrom
gaodayue:fix-poll-auth-db
Aug 31, 2018
Merged

BytesFullResponseHandler should only consume readableBytes of ChannelBuffer#6270
jon-wei merged 1 commit intoapache:masterfrom
gaodayue:fix-poll-auth-db

Conversation

@gaodayue
Copy link
Copy Markdown
Contributor

Fixes #6269

@fjy
Copy link
Copy Markdown
Contributor

fjy commented Aug 30, 2018

@gaodayue do you mind merging with master to fix conflicts?

Copy link
Copy Markdown
Contributor

@gianm gianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, thank you. Please merge with master (this conflicts with #6266). It will help to do git config --local merge.renameLimit 5000 first, which will let git detect the renames properly.

@gianm gianm added this to the 0.12.3 milestone Aug 30, 2018
@gianm
Copy link
Copy Markdown
Contributor

gianm commented Aug 30, 2018

I've added this to 0.12.3, I think it's reasonable to include it there.

@gaodayue
Copy link
Copy Markdown
Contributor Author

It will help to do git config --local merge.renameLimit 5000 first, which will let git detect the renames properly.

Thank you for the tip. Rebased on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants