update insert pending segments logic to synchronous#6283
Closed
FaxianZhao wants to merge 1 commit intoapache:masterfrom
FaxianZhao:sync_insert_pendingSegments
Closed
update insert pending segments logic to synchronous#6283FaxianZhao wants to merge 1 commit intoapache:masterfrom FaxianZhao:sync_insert_pendingSegments
FaxianZhao wants to merge 1 commit intoapache:masterfrom
FaxianZhao:sync_insert_pendingSegments
Conversation
update sync insert pending segments logic update sync insert pending segments logic update sync insert pending segments logic
Contributor
|
Hey @FaxianZhao - any reaosn you closed this? I was just thinking about reviewing this. Sorry we didn't get to it straight away. We have a bit of a backlog of pull requests. |
Contributor
Author
|
Hey @gianm ,I'm sorry for close this without any comment. Now I'm trying to refine it. If I finish it, I will reopen this pull request. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current pending segment id logic is not friendly to my business. It will retry to find the max partition num and plus 1 until reach max retry count.
So I think make this logic TaskLock level synchronous is more smoothly.
Add the SegmentLock.class is my work around solution. Because TaskLock is belong to druid-indexing-service module, it cannot be import to IndexerMetadataStorageCoordinator with druid-server module. Either, add a ReentrantLock in TaskLock, maybe.
If you have some better solution, please let me know.
Thank you.