Skip to content

Tweak isInvalidRows behavior in HadoopTuningConfig#6339

Merged
jon-wei merged 2 commits intoapache:masterfrom
jon-wei:hadoop_tuning
Sep 24, 2018
Merged

Tweak isInvalidRows behavior in HadoopTuningConfig#6339
jon-wei merged 2 commits intoapache:masterfrom
jon-wei:hadoop_tuning

Conversation

@jon-wei
Copy link
Copy Markdown
Contributor

@jon-wei jon-wei commented Sep 17, 2018

Changes behavior so that if maxParseExceptions (new exception handling property) is set, it overrides the old ignoreInvalidRows property.

If maxParseExceptions is null, then fall back to usingignoreInvalidRows.

Also removes the unused "reportParseExceptions" parameter from the hadoop jobs.

@jon-wei jon-wei added this to the 0.13.0 milestone Sep 17, 2018
@jon-wei
Copy link
Copy Markdown
Contributor Author

jon-wei commented Sep 18, 2018

Fixing tests

Copy link
Copy Markdown
Member

@QiuMM QiuMM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there are no docs about this maxParseExceptions .

@jon-wei
Copy link
Copy Markdown
Contributor Author

jon-wei commented Sep 22, 2018

it's not documented yet, planning on doing a PR for that for 0.13.0

@jon-wei jon-wei merged commit 00b0a15 into apache:master Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants