Improve interning in SQLMetadataSegmentManager#6357
Merged
gianm merged 2 commits intoapache:masterfrom Sep 22, 2018
Merged
Conversation
Member
Author
|
Also related to #6358, that I intend to fix later. |
| /** | ||
| * For the garbage collector in Java, it's better to keep new objects short-living, but once they are old enough | ||
| * (i. e. promoted to old generation), try to keep them alive. In {@link #poll()}, we fetch and deserialize all | ||
| * existing segments each time, and them replace them in {@link #dataSourcesRef}. This method allows to use already |
egor-ryashin
approved these changes
Sep 22, 2018
leventov
added a commit
to metamx/druid
that referenced
this pull request
Sep 25, 2018
* Improve interning in SQLMetadataSegmentManager * typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The segments that are stored in
SQLMetadataSegmentManager.DATA_SEGMENT_INTERNERare the same as inSQLMetadataSegmentManager.dataSourcesRef, so we could effectively use the latter for interning. It allows to get rid of one large Map of weak references which are probably bad for GC themselves.Also interning doesn't make sense in
enableDatasource().Originally interning was introduced in #3267.