-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Contributing Moving-Average Query to open source. #6430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
8abe7a5
Contributing Moving-Average Query to open source.
yurmix ef7e0e6
Fix failing code inspections.
yurmix 136eb93
See if explicit types will invoke the correct comparison function.
yurmix 1d98847
Explicitly remove support for druid.generic.useDefaultValueForNull co…
yurmix 63cf6ee
Merge branch 'master' into moving-average-query
yurmix 7bbfc6d
Merge branch 'master' into moving-average-query
yurmix 7b71a26
Update styling and headers for complience.
yurmix 6635751
Refresh code with latest master changes:
yurmix b731780
Small checkstyle fix.
yurmix 95b803a
Checkstyle fixes.
yurmix a21a3ce
Fixing rat errors; Teamcity errors.
yurmix 66daabf
Merge branch 'master' into moving-average-query
yurmix 9591a9d
Removing support theta sketches. Will be added back in this pr or a f…
yurmix 84e48dd
Implements some of the review fixes.
yurmix 0d24960
Contributing Moving-Average Query to open source.
yurmix 0e34829
Fix failing code inspections.
yurmix ae75015
See if explicit types will invoke the correct comparison function.
yurmix 542ecd2
Explicitly remove support for druid.generic.useDefaultValueForNull co…
yurmix 4a04cc7
Update styling and headers for complience.
yurmix 2772206
Refresh code with latest master changes:
yurmix f245403
Small checkstyle fix.
yurmix 70c14a3
Checkstyle fixes.
yurmix 3e349f7
Fixing rat errors; Teamcity errors.
yurmix 516d40b
Removing support theta sketches. Will be added back in this pr or a f…
yurmix 208af0d
Implements some of the review fixes.
yurmix 239bde9
More fixes for review.
yurmix 291cc18
empty merge
yurmix 8157fce
More fixes from review.
yurmix 4f0fbf0
MapBasedRow is Unmodifiable. Create new rows instead of modifying exi…
yurmix 5221a83
Remove more changes related to datasketches support.
yurmix e2a5317
Refactor BaseAverager startFrom field and add a comment.
yurmix 4b425b2
fakeEvents field: Refactor initialization and add comment.
yurmix 8244353
Rename parameters (tiny change).
yurmix f10a343
Fix variable name typo in test (JAN_4).
yurmix c4ad4f5
Fix styling of non camelCase fields.
yurmix 6210196
Fix Preconditions.checkArgument for cycleSize.
yurmix 3ffa46c
Add more documentation to RowBucketIterable and other classes.
yurmix 5f0bbb4
key/value comment on in MovingAverageIterable.
yurmix 0ff63a5
Fix anonymous makeColumnValueSelector returning null.
yurmix e304b16
Merge branch 'master' into moving-average-query
yurmix e313a2b
Replace IdentityYieldingAccumolator with Yielders.each().
yurmix 6708720
* internalNext() should return null instead of throwing exception.
yurmix fa3fbbc
Harden MovingAverageIterableTest (Switch anyOf to exact match).
yurmix 304c43d
Change internalNext() from recursion to iteration; Simplify next() an…
yurmix 81d0909
Remove unused imports.
yurmix 716665e
Merge branch 'master' into moving-average-query
yurmix 1c577ae
Address review comments.
yurmix ab1ae00
Rename fakeEvents to emptyEvents.
yurmix 295916d
Merge branch 'master' into moving-average-query
yurmix f26c2f6
Merge branch 'master' of github.com:apache/incubator-druid into movin…
yurmix 7b6f56e
Remove redundant parameter key from computeMovingAverage.
yurmix 167efa2
Merge branch 'master' of github.com:apache/incubator-druid into movin…
yurmix 8fccf19
Check yielder as well in RowBucketIterable#hasNext()
yurmix 001b061
Fix javadoc.
yurmix ac43cc0
Merge branch 'master' of github.com:apache/incubator-druid into movin…
yurmix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
337 changes: 337 additions & 0 deletions
337
docs/content/development/extensions-contrib/moving-average-query.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,337 @@ | ||
| --- | ||
| layout: doc_page | ||
| --- | ||
|
|
||
| <!-- | ||
| ~ Licensed to the Apache Software Foundation (ASF) under one | ||
| ~ or more contributor license agreements. See the NOTICE file | ||
| ~ distributed with this work for additional information | ||
| ~ regarding copyright ownership. The ASF licenses this file | ||
| ~ to you under the Apache License, Version 2.0 (the | ||
| ~ "License"); you may not use this file except in compliance | ||
| ~ with the License. You may obtain a copy of the License at | ||
| ~ | ||
| ~ http://www.apache.org/licenses/LICENSE-2.0 | ||
| ~ | ||
| ~ Unless required by applicable law or agreed to in writing, | ||
| ~ software distributed under the License is distributed on an | ||
| ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| ~ KIND, either express or implied. See the License for the | ||
| ~ specific language governing permissions and limitations | ||
| ~ under the License. | ||
| --> | ||
|
|
||
| # Moving Average Queries | ||
|
|
||
| ## Overview | ||
| **Moving Average Query** is an extension which provides support for [Moving Average](https://en.wikipedia.org/wiki/Moving_average) and other Aggregate [Window Functions](https://en.wikibooks.org/wiki/Structured_Query_Language/Window_functions) in Druid queries. | ||
|
|
||
| These Aggregate Window Functions consume standard Druid Aggregators and outputs additional windowed aggregates called [Averagers](#averagers). | ||
|
|
||
| #### High level algorithm | ||
|
|
||
| Moving Average encapsulates the [groupBy query](../../querying/groupbyquery.html) (Or [timeseries](../../querying/timeseriesquery.html) in case of no dimensions) in order to rely on the maturity of these query types. | ||
|
|
||
| It runs the query in two main phases: | ||
| 1. Runs an inner [groupBy](../../querying/groupbyquery.html) or [timeseries](../../querying/timeseriesquery.html) query to compute Aggregators (i.e. daily count of events). | ||
| 2. Passes over aggregated results in Broker, in order to compute Averagers (i.e. moving 7 day average of the daily count). | ||
|
|
||
| #### Main enhancements provided by this extension: | ||
| 1. Functionality: Extending druid query functionality (i.e. initial introduction of Window Functions). | ||
| 2. Performance: Improving performance of such moving aggregations by eliminating multiple segment scans. | ||
|
|
||
| #### Further reading | ||
| [Moving Average](https://en.wikipedia.org/wiki/Moving_average) | ||
|
|
||
| [Window Functions](https://en.wikibooks.org/wiki/Structured_Query_Language/Window_functions) | ||
|
|
||
| [Analytic Functions](https://cloud.google.com/bigquery/docs/reference/standard-sql/analytic-function-concepts) | ||
|
|
||
|
|
||
| ## Operations | ||
| To use this extension, make sure to [load](../../operations/including-extensions.html) `druid-moving-average-query` only to the Broker. | ||
|
|
||
| ## Configuration | ||
| There are currently no configuration properties specific to Moving Average. | ||
|
|
||
| ## Limitations | ||
| * movingAverage is missing support for the following groupBy properties: `subtotalsSpec`, `virtualColumns`. | ||
| * movingAverage is missing support for the following timeseries properties: `descending`. | ||
| * movingAverage is missing support for [SQL-compatible null handling](https://github.com/apache/incubator-druid/issues/4349) (So setting druid.generic.useDefaultValueForNull in configuration will give an error). | ||
|
|
||
| ##Query spec: | ||
| * Most properties in the query spec derived from [groupBy query](../../querying/groupbyquery.html) / [timeseries](../../querying/timeseriesquery.html), see documentation for these query types. | ||
|
|
||
| |property|description|required?| | ||
| |--------|-----------|---------| | ||
| |queryType|This String should always be "movingAverage"; this is the first thing Druid looks at to figure out how to interpret the query.|yes| | ||
| |dataSource|A String or Object defining the data source to query, very similar to a table in a relational database. See [DataSource](../../querying/datasource.html) for more information.|yes| | ||
| |dimensions|A JSON list of [DimensionSpec](../../querying/dimensionspecs.html) (Notice that property is optional)|no| | ||
| |limitSpec|See [LimitSpec](../../querying/limitspec.html)|no| | ||
| |having|See [Having](../../querying/having.html)|no| | ||
| |granularity|A period granilarity; See [Period Granularities](../../querying/granularities.html#period-granularities)|yes| | ||
| |filter|See [Filters](../../querying/filters.html)|no| | ||
| |aggregations|Aggregations forms the input to Averagers; See [Aggregations](../../querying/aggregations.html)|yes| | ||
| |postAggregations|Supports only aggregations as input; See [Post Aggregations](../../querying/post-aggregations.html)|no| | ||
| |intervals|A JSON Object representing ISO-8601 Intervals. This defines the time ranges to run the query over.|yes| | ||
| |context|An additional JSON Object which can be used to specify certain flags.|no| | ||
| |averagers|Defines the moving average function; See [Averagers](#averagers)|yes| | ||
| |postAveragers|Support input of both averagers and aggregations; Syntax is identical to postAggregations (See [Post Aggregations](../../querying/post-aggregations.html))|no| | ||
|
|
||
| ## Averagers | ||
|
|
||
| Averagers are used to define the Moving-Average function. Averagers are not limited to an average - they can also provide other types of window functions such as MAX()/MIN(). | ||
|
|
||
| ### Properties | ||
|
|
||
| These are properties which are common to all Averagers: | ||
|
|
||
| |property|description|required?| | ||
| |--------|-----------|---------| | ||
| |type|Averager type; See [Averager types](#averager-types)|yes| | ||
| |name|Averager name|yes| | ||
| |fieldName|Input name (An aggregation name)|yes| | ||
| |buckets|Number of lookback buckets (time periods), including current one. Must be >0|yes| | ||
| |cycleSize|Cycle size; Used to calculate day-of-week option; See [Cycle size (Day of Week)](#cycle-size-day-of-week)|no, defaults to 1| | ||
|
|
||
|
|
||
| ### Averager types: | ||
|
|
||
| * [Standard averagers](#standard-averagers): | ||
| * doubleMean | ||
| * doubleMeanNoNulls | ||
| * doubleMax | ||
| * doubleMin | ||
| * longMean | ||
| * longMeanNoNulls | ||
| * longMax | ||
| * longMin | ||
|
|
||
| #### Standard averagers | ||
|
|
||
| These averagers offer four functions: | ||
| * Mean (Average) | ||
| * MeanNoNulls (Ignores empty buckets). | ||
| * Max | ||
| * Min | ||
|
|
||
| **Ignoring nulls**: | ||
| Using a MeanNoNulls averager is useful when the interval starts at the dataset beginning time. | ||
| In that case, the first records will ignore missing buckets and average won't be artificially low. | ||
| However, this also means that empty days in a sparse dataset will also be ignored. | ||
|
|
||
| Example of usage: | ||
| ```json | ||
| { "type" : "doubleMean", "name" : <output_name>, "fieldName": <input_name> } | ||
| ``` | ||
|
|
||
| ### Cycle size (Day of Week) | ||
| This optional parameter is used to calculate over a single bucket within each cycle instead of all buckets. | ||
| A prime example would be weekly buckets, resulting in a Day of Week calculation. (Other examples: Month of year, Hour of day). | ||
|
|
||
| I.e. when using these parameters: | ||
| * *granularity*: period=P1D (daily) | ||
| * *buckets*: 28 | ||
| * *cycleSize*: 7 | ||
|
|
||
| Within each output record, the averager will compute the result over the following buckets: current (#0), #7, #14, #21. | ||
| Whereas without specifying cycleSize it would have computed over all 28 buckets. | ||
|
|
||
| ## Examples | ||
|
|
||
| All examples are based on the Wikipedia dataset provided in the Druid [tutorials](../../tutorials/index.html). | ||
|
|
||
| ### Basic example | ||
|
|
||
| Calculating a 7-buckets moving average for Wikipedia edit deltas. | ||
|
|
||
| Query syntax: | ||
| ```json | ||
| { | ||
| "queryType": "movingAverage", | ||
| "dataSource": "wikipedia", | ||
| "granularity": { | ||
| "type": "period", | ||
| "period": "PT30M" | ||
| }, | ||
| "intervals": [ | ||
| "2015-09-12T00:00:00Z/2015-09-13T00:00:00Z" | ||
| ], | ||
| "aggregations": [ | ||
| { | ||
| "name": "delta30Min", | ||
| "fieldName": "delta", | ||
| "type": "longSum" | ||
| } | ||
| ], | ||
| "averagers": [ | ||
| { | ||
| "name": "trailing30MinChanges", | ||
| "fieldName": "delta30Min", | ||
| "type": "longMean", | ||
| "buckets": 7 | ||
| } | ||
| ] | ||
| } | ||
| ``` | ||
|
|
||
| Result: | ||
| ```json | ||
| [ { | ||
| "version" : "v1", | ||
| "timestamp" : "2015-09-12T00:30:00.000Z", | ||
| "event" : { | ||
| "delta30Min" : 30490, | ||
| "trailing30MinChanges" : 4355.714285714285 | ||
| } | ||
| }, { | ||
| "version" : "v1", | ||
| "timestamp" : "2015-09-12T01:00:00.000Z", | ||
| "event" : { | ||
| "delta30Min" : 96526, | ||
| "trailing30MinChanges" : 18145.14285714286 | ||
| } | ||
| }, { | ||
| ... | ||
| ... | ||
| ... | ||
| }, { | ||
| "version" : "v1", | ||
| "timestamp" : "2015-09-12T23:00:00.000Z", | ||
| "event" : { | ||
| "delta30Min" : 119100, | ||
| "trailing30MinChanges" : 198697.2857142857 | ||
| } | ||
| }, { | ||
| "version" : "v1", | ||
| "timestamp" : "2015-09-12T23:30:00.000Z", | ||
| "event" : { | ||
| "delta30Min" : 177882, | ||
| "trailing30MinChanges" : 193890.0 | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ### Post averager example | ||
|
|
||
| Calculating a 7-buckets moving average for Wikipedia edit deltas, plus a ratio between the current period and the moving average. | ||
|
|
||
| Query syntax: | ||
| ```json | ||
| { | ||
| "queryType": "movingAverage", | ||
| "dataSource": "wikipedia", | ||
| "granularity": { | ||
| "type": "period", | ||
| "period": "PT30M" | ||
| }, | ||
| "intervals": [ | ||
| "2015-09-12T22:00:00Z/2015-09-13T00:00:00Z" | ||
| ], | ||
| "aggregations": [ | ||
| { | ||
| "name": "delta30Min", | ||
| "fieldName": "delta", | ||
| "type": "longSum" | ||
| } | ||
| ], | ||
| "averagers": [ | ||
| { | ||
| "name": "trailing30MinChanges", | ||
| "fieldName": "delta30Min", | ||
| "type": "longMean", | ||
| "buckets": 7 | ||
| } | ||
| ], | ||
| "postAveragers" : [ | ||
| { | ||
| "name": "ratioTrailing30MinChanges", | ||
| "type": "arithmetic", | ||
| "fn": "/", | ||
| "fields": [ | ||
| { | ||
| "type": "fieldAccess", | ||
| "fieldName": "delta30Min" | ||
| }, | ||
| { | ||
| "type": "fieldAccess", | ||
| "fieldName": "trailing30MinChanges" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ``` | ||
|
|
||
| Result: | ||
| ```json | ||
| [ { | ||
| "version" : "v1", | ||
| "timestamp" : "2015-09-12T22:00:00.000Z", | ||
| "event" : { | ||
| "delta30Min" : 144269, | ||
| "trailing30MinChanges" : 204088.14285714287, | ||
| "ratioTrailing30MinChanges" : 0.7068955500319539 | ||
| } | ||
| }, { | ||
| "version" : "v1", | ||
| "timestamp" : "2015-09-12T22:30:00.000Z", | ||
| "event" : { | ||
| "delta30Min" : 242860, | ||
| "trailing30MinChanges" : 214031.57142857142, | ||
| "ratioTrailing30MinChanges" : 1.134692411867141 | ||
| } | ||
| }, { | ||
| "version" : "v1", | ||
| "timestamp" : "2015-09-12T23:00:00.000Z", | ||
| "event" : { | ||
| "delta30Min" : 119100, | ||
| "trailing30MinChanges" : 198697.2857142857, | ||
| "ratioTrailing30MinChanges" : 0.5994042624782422 | ||
| } | ||
| }, { | ||
| "version" : "v1", | ||
| "timestamp" : "2015-09-12T23:30:00.000Z", | ||
| "event" : { | ||
| "delta30Min" : 177882, | ||
| "trailing30MinChanges" : 193890.0, | ||
| "ratioTrailing30MinChanges" : 0.9174377224199288 | ||
| } | ||
| } ] | ||
| ``` | ||
|
|
||
|
|
||
| ### Cycle size example | ||
|
|
||
| Calculating an average of every first 10-minutes of the last 3 hours: | ||
|
|
||
| Query syntax: | ||
| ```json | ||
| { | ||
| "queryType": "movingAverage", | ||
| "dataSource": "wikipedia", | ||
| "granularity": { | ||
| "type": "period", | ||
| "period": "PT10M" | ||
| }, | ||
| "intervals": [ | ||
| "2015-09-12T00:00:00Z/2015-09-13T00:00:00Z" | ||
| ], | ||
| "aggregations": [ | ||
| { | ||
| "name": "delta10Min", | ||
| "fieldName": "delta", | ||
| "type": "doubleSum" | ||
| } | ||
| ], | ||
| "averagers": [ | ||
| { | ||
| "name": "trailing10MinPerHourChanges", | ||
| "fieldName": "delta10Min", | ||
| "type": "doubleMeanNoNulls", | ||
| "buckets": 18, | ||
| "cycleSize": 6 | ||
| } | ||
| ] | ||
| } | ||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| <!-- | ||
| ~ Licensed to the Apache Software Foundation (ASF) under one | ||
| ~ or more contributor license agreements. See the NOTICE file | ||
| ~ distributed with this work for additional information | ||
| ~ regarding copyright ownership. The ASF licenses this file | ||
| ~ to you under the Apache License, Version 2.0 (the | ||
| ~ "License"); you may not use this file except in compliance | ||
| ~ with the License. You may obtain a copy of the License at | ||
| ~ | ||
| ~ http://www.apache.org/licenses/LICENSE-2.0 | ||
| ~ | ||
| ~ Unless required by applicable law or agreed to in writing, | ||
| ~ software distributed under the License is distributed on an | ||
| ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| ~ KIND, either express or implied. See the License for the | ||
| ~ specific language governing permissions and limitations | ||
| ~ under the License. | ||
| --> | ||
|
|
||
| druid-moving-average-query | ||
| ============= | ||
|
|
||
| Overview | ||
| ============= | ||
| **Moving Average Query** is an extension which provides support for [Moving Average](https://en.wikipedia.org/wiki/Moving_average) and other Aggregate [Window Functions](https://en.wikibooks.org/wiki/Structured_Query_Language/Window_functions) in Druid queries. | ||
|
|
||
| Documentation | ||
| ============= | ||
| See the druid.io website or under [Druid Github Repo](https://github.com/apache/incubator-druid/tree/master/docs/content/development/extensions-contrib/moving-average-query.md). |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.