Skip to content

fix druid-bloom-filter thread-safety #6584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
b-slim merged 6 commits into from
Nov 9, 2018
Merged

fix druid-bloom-filter thread-safety #6584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b83b9d
use BloomFilter instead of BloomKFilter since the latters test method…
clintropolis Oct 30, 2018
92510ca
fix formatting
clintropolis Nov 7, 2018
33781ae
style and forbidden api
clintropolis Nov 7, 2018
93b8e8f
remove redundant hive notice entry
clintropolis Nov 8, 2018
a51e66c
add todo with note to delete copied implementation and link to relate…
clintropolis Nov 9, 2018
7ee7fb8
better fix for masks than ThreadLocal
clintropolis Nov 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions NOTICE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ This product contains a modified version of Andrew Duffy's java-alphanum library
* HOMEPAGE:
* https://github.com/amjjd/java-alphanum

This product contains conjunctive normal form conversion code and a variance aggregator algorithm adapted from Apache Hive
This product contains conjunctive normal form conversion code, a variance aggregator algorithm, and bloom filter adapted from Apache Hive
* LICENSE:
* https://github.com/apache/hive/blob/branch-2.0/LICENSE (Apache License, Version 2.0)
* HOMEPAGE:
Expand Down Expand Up @@ -91,4 +91,4 @@ This product contains modified versions of the Dockerfile and related configurat
* HOMEPAGE:
* https://github.com/sequenceiq/hadoop-docker/
* COMMIT TAG:
* update this when this patch is committed
* update this when this patch is committed
2 changes: 1 addition & 1 deletion ...druid-bloom-filter/src/main/java/org/apache/druid/guice/BloomFilterSerializersModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
import com.fasterxml.jackson.databind.module.SimpleModule;
import com.fasterxml.jackson.databind.ser.std.StdSerializer;
import org.apache.druid.query.filter.BloomDimFilter;
import org.apache.druid.query.filter.BloomKFilter;
import org.apache.druid.query.filter.BloomKFilterHolder;
import org.apache.hive.common.util.BloomKFilter;

import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
Expand Down
1 change: 0 additions & 1 deletion ...s-core/druid-bloom-filter/src/main/java/org/apache/druid/query/filter/BloomDimFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
import org.apache.druid.query.cache.CacheKeyBuilder;
import org.apache.druid.query.extraction.ExtractionFn;
import org.apache.druid.segment.filter.DimensionPredicateFilter;
import org.apache.hive.common.util.BloomKFilter;

import java.util.HashSet;

Expand Down
Loading