Fix a race in FileSessionCredentialsProvider#6664
Merged
leventov merged 3 commits intoapache:masterfrom Nov 27, 2018
Merged
Conversation
Member
Author
|
An issue about reader/writer race: #6665 |
Member
Author
|
This issue might be a tip of an iceberg: #6666 |
jihoonson
reviewed
Nov 27, 2018
| private volatile String accessKey; | ||
| private volatile String secretKey; | ||
| private final String sessionCredentialsFile; | ||
| private AWSSessionCredentials awsSessionCredentials; |
Contributor
There was a problem hiding this comment.
Sorry for leaving a comment after LGTM, but is this needed to be volatile?
Member
Author
There was a problem hiding this comment.
It doesn't need to be volatile. From JMM point of view, volatile on this field changes anything and doesn't provide any extra guarantees.
Member
Author
There was a problem hiding this comment.
I'll leave this as a comment in code though.
drcrallen
approved these changes
Nov 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sessionToken,accessKeyandsecretKeymust be updated atomically.Another race is possible between the file updater and the Druid process reading the file. It could be enforced only with mandatory file locking, but file locking is advisory by default in Linux.