emit logs that are only useful for debugging at debug level#6741
Merged
asdf2014 merged 3 commits intoapache:masterfrom Dec 17, 2018
Merged
emit logs that are only useful for debugging at debug level#6741asdf2014 merged 3 commits intoapache:masterfrom
asdf2014 merged 3 commits intoapache:masterfrom
Conversation
jihoonson
approved these changes
Dec 17, 2018
gianm
reviewed
Dec 18, 2018
| mergeBufferTotalSize += bufferAllocation.rhs; | ||
| ByteBufferUtils.free(bufferAllocation.lhs); | ||
| } | ||
| log.info("Freed [,%d] bytes of dictionary merging direct buffers", mergeBufferTotalSize); |
gianm
reviewed
Dec 18, 2018
| LOG.info( | ||
| "Submitted a compactTask[%s] for segments[%s]", | ||
| taskId, | ||
| segmentsToCompact.stream().map(DataSegment::getIdentifier).collect(Collectors.joining(",")) |
Contributor
There was a problem hiding this comment.
This joiner thing looks like it would be a good utility function. Including a space after the comma would be a good idea, too, I think, since it visually spaces them out a bit more and would make the log line easier on the eyes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make log volume a bit more chill.
Any other requests for making things a bit quieter?