Consider using Roaring batch iterators#6770
Closed
richardstartin wants to merge 3 commits intoapache:masterfrom
richardstartin:faster-roaring-iterators
Closed
Consider using Roaring batch iterators#6770richardstartin wants to merge 3 commits intoapache:masterfrom richardstartin:faster-roaring-iterators
richardstartin wants to merge 3 commits intoapache:masterfrom
richardstartin:faster-roaring-iterators
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a patch which replaces the
IntIteratorimplementation with one that wraps aBatchIterator- an iterator which extracts values from the bitmap into a buffer in batches, and can be a lot faster. This relies on a space time tradeoff, so probably requires heuristics or a configurable cardinality threshold to choose when the new kind of iterator is used. These iterators are also more expensive to clone, which seems to be done extensively in druid.At b5df73e (with batch iterators) I get
At 7a09cde (without batch iterators) I get:
Note that using batch iterators via the
IntIteratorinterface costs at least 2x throughput compared to using them via theBatchIteratorinterface.