Skip to content

datasketches quantiles module - implemented makeAggregateCombiner #6882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjy merged 2 commits into from
Jan 17, 2019
Merged

datasketches quantiles module - implemented makeAggregateCombiner #6882

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46633b9
implemented makeAggregateCombiner
AlexanderSaydakov Jan 17, 2019
a7c72f2
fixed import order
AlexanderSaydakov Jan 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions ...apache/druid/query/aggregation/datasketches/quantiles/DoublesSketchAggregatorFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,20 @@
import com.yahoo.sketches.quantiles.DoublesSketch;
import com.yahoo.sketches.quantiles.DoublesUnion;
import org.apache.druid.java.util.common.IAE;
import org.apache.druid.query.aggregation.AggregateCombiner;
import org.apache.druid.query.aggregation.Aggregator;
import org.apache.druid.query.aggregation.AggregatorFactory;
import org.apache.druid.query.aggregation.AggregatorFactoryNotMergeableException;
import org.apache.druid.query.aggregation.AggregatorUtil;
import org.apache.druid.query.aggregation.BufferAggregator;
import org.apache.druid.query.aggregation.ObjectAggregateCombiner;
import org.apache.druid.query.cache.CacheKeyBuilder;
import org.apache.druid.segment.ColumnSelectorFactory;
import org.apache.druid.segment.ColumnValueSelector;
import org.apache.druid.segment.NilColumnValueSelector;
import org.apache.druid.segment.column.ValueType;

import javax.annotation.Nullable;
import java.util.Collections;
import java.util.Comparator;
import java.util.List;
Expand Down Expand Up @@ -137,6 +140,42 @@ public Object combine(final Object lhs, final Object rhs)
return union.getResultAndReset();
}

@Override
public AggregateCombiner makeAggregateCombiner()
{
return new ObjectAggregateCombiner<DoublesSketch>()
{
private final DoublesUnion union = DoublesUnion.builder().setMaxK(k).build();

@Override
public void reset(final ColumnValueSelector selector)
{
union.reset();
fold(selector);
}

@Override
public void fold(final ColumnValueSelector selector)
{
final DoublesSketch sketch = (DoublesSketch) selector.getObject();
union.update(sketch);
}

@Nullable
@Override
public DoublesSketch getObject()
{
return union.getResult();
}

@Override
public Class<DoublesSketch> classOfObject()
{
return DoublesSketch.class;
}
};
}

@Override
@JsonProperty
public String getName()
Expand Down